Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deprecated slack files.upload is replaced with new slack bot APIs #242

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix: deprecated slack files.upload is replaced with new slack bot APIs #242

wants to merge 11 commits into from

Conversation

iamatulsingh
Copy link

@iamatulsingh iamatulsingh commented Sep 2, 2024 •
edited
Loading

ENHANCEMENT

The original web API method for uploading files to Slack, [files.upload](https://api.slack.com/methods/files.upload), is being sunset on March 11, 2025.

As of May 16, 2024, newly-created apps are no longer able to use this API method.

Existing apps & integrations should migrate away from files.upload and instead leverage a combination of two APIs: [files.getUploadURLExternal](https://api.slack.com/methods/files.getUploadURLExternal) and [files.completeUploadExternal](https://api.slack.com/methods/files.completeUploadExternal). The use of these two methods is more reliable, especially when uploading large files.

A detailed breakdown of how to use these two API methods is described in our [Uploading files documentation](https://api.slack.com/messaging/files#uploading_files).

Mentioned in some issues #235

As mentioned here https://api.slack.com/changelog/2024-04-a-better-way-to-upload-files-is-here-to-stay I mad changes to use new APIs now with backward compatibility for Slack.

@iamatulsingh iamatulsingh requested a review from a team as a code owner September 2, 2024 08:53
@CLAassistant
Copy link

CLAassistant commented Sep 2, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@iamatulsingh iamatulsingh changed the title fix: deprecated slack files.upload is optional now new slack bots fix: deprecated slack files.upload is optional now with new slack bot APIs Sep 2, 2024
@iamatulsingh iamatulsingh mentioned this pull request Sep 2, 2024
Closed
stevesg
stevesg reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@stevesg stevesg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

It's not commonplace in Grafana to reach into environment variables directly, so we'll need to find an alternative to this, some options:

  1. Don't make it configurable, just use the new API and be done with it.
  2. Make it configurable via Grafana global config level, pass the config down
  3. Make it configurable on the integration level

@iamatulsingh
Copy link
Author

Thank you for working on this!

It's not commonplace in Grafana to reach into environment variables directly, so we'll need to find an alternative to this, some options:

  1. Don't make it configurable, just use the new API and be done with it.
  2. Make it configurable via Grafana global config level, pass the config down
  3. Make it configurable on the integration level

Thank you for your time. I have used the new API and removed the old one completely.

@iamatulsingh iamatulsingh changed the title fix: deprecated slack files.upload is optional now with new slack bot APIs fix: deprecated slack files.upload is replaced with new slack bot APIs Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevesg stevesg stevesg left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Alerting
Status: In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamatulsingh @CLAassistant @stevesg